chrome/browser/extensions/api/tabs/windows_event_router.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/windows_event_router.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/windows_event_router.cc

diff --git a/chrome/browser/extensions/api/tabs/windows_event_router.cc b/chrome/browser/extensions/api/tabs/windows_event_router.cc

index ba1f49c6746f6a3b6f2535bccd1e3216537cc6c6..6c0251f4da0ef443a5d02b0f0c8013749810f654 100644

--- a/chrome/browser/extensions/api/tabs/windows_event_router.cc

+++ b/chrome/browser/extensions/api/tabs/windows_event_router.cc

@@ -196,9 +196,7 @@ void WindowsEventRouter::OnWindowControllerAdded(

return;

std::unique_ptr<base::ListValue> args(new base::ListValue());

- base::DictionaryValue* window_dictionary =

- window_controller->CreateWindowValue();

- args->Append(window_dictionary);

+ args->Append(window_controller->CreateWindowValue());

DispatchEvent(events::WINDOWS_ON_CREATED, windows::OnCreated::kEventName,

window_controller, std::move(args));

}