Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
index 927b7d6766cfb29abca4efa905b7349d4d21e170..5145d00a8a4e1ccc1d3ab3b9e7f46edcf55e8a57 100644
--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h"
#include <memory>
+#include <utility>
#include "base/memory/scoped_vector.h"
#include "base/values.h"
@@ -122,11 +123,11 @@ bool SignedInDevicesGetFunction::RunSync() {
if (is_local) {
std::unique_ptr<DeviceInfo> device =
GetLocalDeviceInfo(extension_id(), GetProfile());
- base::ListValue* result = new base::ListValue();
+ std::unique_ptr<base::ListValue> result(new base::ListValue());
if (device.get()) {
result->Append(device->ToValue());
}
- SetResult(result);
+ SetResult(std::move(result));
return true;
}
@@ -141,7 +142,7 @@ bool SignedInDevicesGetFunction::RunSync() {
result->Append((*it)->ToValue());
}
- SetResult(result.release());
+ SetResult(std::move(result));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698