chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/file_system/file_system_api.cc ('K') | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc » ('j') | chrome/browser/extensions/extension_tab_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

index cfa1d2785871d5e0e793b02c9ab59cfb59077dda..b9f5212178edf2ef86a5dd6a3431d665c6b96c54 100644

--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

@@ -7,6 +7,7 @@

#include <utility>

#include "base/lazy_instance.h"

+#include "base/memory/ptr_util.h"

#include "base/values.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/signin/chrome_proximity_auth_client.h"

@@ -54,7 +55,7 @@ ScreenlockPrivateGetLockedFunction::ScreenlockPrivateGetLockedFunction() {}

ScreenlockPrivateGetLockedFunction::~ScreenlockPrivateGetLockedFunction() {}

bool ScreenlockPrivateGetLockedFunction::RunAsync() {

- SetResult(new base::FundamentalValue(

+ SetResult(base::MakeUnique<base::FundamentalValue>(

proximity_auth::ScreenlockBridge::Get()->IsLocked()));

SendResponse(error_.empty());

return true;