Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5796)

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/chrome_direct_setting.cc
diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
index 87de9bb55ada2475ba7cd408d26bc65540dfb48f..3dc56c12f959ee03318a8e54f48f4688536ff9d8 100644
--- a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/extensions/api/preference/chrome_direct_setting.h"
+#include <utility>
+
#include "base/containers/hash_tables.h"
#include "base/lazy_instance.h"
#include "base/values.h"
@@ -38,7 +40,7 @@ bool GetDirectSettingFunction::RunSync() {
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
result->Set(preference_api_constants::kValue, value->DeepCopy());
- SetResult(result.release());
+ SetResult(std::move(result));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698