Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2113)

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/page_capture/page_capture_api.cc
diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.cc b/chrome/browser/extensions/api/page_capture/page_capture_api.cc
index 66e5bb12af6596cbea3a7607050b9c0dbaf92942..e1c962ceda3fbed6f6d34dd8a96ae9b9edfc51c1 100644
--- a/chrome/browser/extensions/api/page_capture/page_capture_api.cc
+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/api/page_capture/page_capture_api.h"
#include <limits>
+#include <memory>
#include "base/bind.h"
#include "base/files/file_util.h"
@@ -174,10 +175,10 @@ void PageCaptureSaveAsMHTMLFunction::ReturnSuccess(int64_t file_size) {
ChildProcessSecurityPolicy::GetInstance()->GrantReadFile(
child_id, mhtml_path_);
- base::DictionaryValue* dict = new base::DictionaryValue();
- SetResult(dict);
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetString("mhtmlFilePath", mhtml_path_.value());
dict->SetInteger("mhtmlFileLength", file_size);
+ SetResult(std::move(dict));
SendResponse(true);

Powered by Google App Engine
This is Rietveld 408576698