Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
diff --git a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
index 4ba270d32d1a8e4a0eb77fb1a2689ac2fca532d8..191c7978a586daab1a2f424b800f2df39eee9845 100644
--- a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
+++ b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
@@ -8,6 +8,7 @@
#include <algorithm>
+#include "base/memory/ptr_util.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h"
#include "base/metrics/sparse_histogram.h"
@@ -42,7 +43,7 @@ const size_t kMaxBuckets = 10000; // We don't ever want more than these many
} // namespace
bool MetricsPrivateGetIsCrashReportingEnabledFunction::RunSync() {
- SetResult(new base::FundamentalValue(
+ SetResult(base::MakeUnique<base::FundamentalValue>(
ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled()));
return true;
}
@@ -51,7 +52,8 @@ bool MetricsPrivateGetFieldTrialFunction::RunSync() {
std::string name;
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &name));
- SetResult(new base::StringValue(base::FieldTrialList::FindFullName(name)));
+ SetResult(base::MakeUnique<base::StringValue>(
+ base::FieldTrialList::FindFullName(name)));
return true;
}
@@ -63,7 +65,7 @@ bool MetricsPrivateGetVariationParamsFunction::RunSync() {
GetVariationParams::Results::Params result;
if (variations::GetVariationParams(params->name,
&result.additional_properties)) {
- SetResult(result.ToValue().release());
+ SetResult(result.ToValue());
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698