chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/content_settings/content_settings_api.cc ('K') | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

index b2d67d8267f4e5560a6623b44b187ece34bdacac..82d24612d6c0c98c0dd5ace7f862ca7f4fc2b2d5 100644

--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

@@ -65,7 +65,7 @@ void DesktopCaptureChooseDesktopMediaFunctionBase::Cancel() {

scoped_refptr<DesktopCaptureChooseDesktopMediaFunctionBase> self(this);

if (picker_) {

picker_.reset();

- SetResult(new base::StringValue(std::string()));

+ SetResult(base::MakeUnique<base::StringValue>(std::string()));

SendResponse(true);

}

@@ -230,7 +230,7 @@ void DesktopCaptureChooseDesktopMediaFunctionBase::OnPickerDialogResults(

extension()->name());

}

- SetResult(new base::StringValue(result));

+ SetResult(base::MakeUnique<base::StringValue>(result));

SendResponse(true);

}