chrome/browser/extensions/api/debugger/debugger_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/debugger/debugger_api.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc

index e5be551b36d325e6c6142dcdd26c8607f5dc2be6..35602f46174aa9faf581fff1dba7086ee571d0b1 100644

--- a/chrome/browser/extensions/api/debugger/debugger_api.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc

@@ -729,7 +729,7 @@ void DebuggerGetTargetsFunction::SendTargetList(

for (size_t i = 0; i < target_list.size(); ++i)

result->Append(SerializeTarget(*target_list[i]));

STLDeleteContainerPointers(target_list.begin(), target_list.end());

- SetResult(result.release());

+ SetResult(std::move(result));

SendResponse(true);

}