chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "" -> std::string() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc ('k') | chrome/browser/chromeos/extensions/first_run_private_api.cc » ('j') | chrome/browser/chromeos/extensions/wallpaper_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

index 3e7c03f8144ed617baebe7efa5f4e7bb03a6d89d..ec5c7fcc1a02fcaeeaca4414d192c845e4893e9b 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

@@ -10,6 +10,7 @@

#include <string>

#include <vector>

+#include "base/memory/ptr_util.h"

#include "chrome/browser/chromeos/drive/file_system_util.h"

#include "chrome/browser/chromeos/file_manager/fileapi_util.h"

#include "chrome/browser/chromeos/fileapi/file_system_backend.h"

@@ -235,7 +236,7 @@ bool FileManagerPrivateInternalSetDefaultTaskFunction::RunSync() {

// TODO(gspencer): Fix file manager so that it never tries to set default in

// cases where extensionless local files are part of the selection.

if (suffixes.empty() && mime_types.empty()) {

- SetResult(new base::FundamentalValue(true));

+ SetResult(base::MakeUnique<base::FundamentalValue>(true));

return true;

}