chrome/browser/extensions/window_controller.h - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/window_controller.h

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/window_controller.h

diff --git a/chrome/browser/extensions/window_controller.h b/chrome/browser/extensions/window_controller.h

index 3a2673f9277ae957971983d3642324d08736facc..deb33191816ec8c652593a53c0869fcc06e7f373 100644

--- a/chrome/browser/extensions/window_controller.h

+++ b/chrome/browser/extensions/window_controller.h

@@ -80,10 +80,10 @@ class WindowController {

// Populates a dictionary for the Window object. Override this to set

// implementation specific properties (call the base implementation first to

// set common properties).

- virtual base::DictionaryValue* CreateWindowValue() const;

dcheng 2016/05/19 03:40:25 Devirtualized, because none of the overloads did a

+ std::unique_ptr<base::DictionaryValue> CreateWindowValue() const;

// Populates a dictionary for the Window object, including a list of tabs.

- virtual base::DictionaryValue* CreateWindowValueWithTabs(

+ virtual std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(

const extensions::Extension* extension) const = 0;

virtual std::unique_ptr<api::tabs::Tab> CreateTabObject(