Remove ExtensionFunction::SetResult(T*) overload.

chrome/browser/extensions/window_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_WINDOW_CONTROLLER_H_
 #define CHROME_BROWSER_EXTENSIONS_WINDOW_CONTROLLER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 62 matching lines @@
 
   // Return an id uniquely identifying the window.
   virtual int GetWindowId() const = 0;
 
   // Return the type name for the window.
   virtual std::string GetWindowTypeText() const = 0;
 
   // Populates a dictionary for the Window object. Override this to set
   // implementation specific properties (call the base implementation first to
   // set common properties).
-  virtual base::DictionaryValue* CreateWindowValue() const;

[dcheng, 2016/05/19 03:40:25]

Devirtualized, because none of the overloads did anything interesting.

+  std::unique_ptr<base::DictionaryValue> CreateWindowValue() const;
 
   // Populates a dictionary for the Window object, including a list of tabs.
-  virtual base::DictionaryValue* CreateWindowValueWithTabs(
+  virtual std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(
       const extensions::Extension* extension) const = 0;
 
   virtual std::unique_ptr<api::tabs::Tab> CreateTabObject(
       const extensions::Extension* extension,
       int tab_index) const = 0;
 
   // DEPRECATED: Use std::unique_ptr<api::tabs::Tab> CreateTabObject(...)
   virtual base::DictionaryValue* CreateTabValue(
       const extensions::Extension* extension, int tab_index) const = 0;
 
@@ skipping 20 matching lines @@
  private:
   ui::BaseWindow* window_;
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowController);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_WINDOW_CONTROLLER_H_