Implement the gattserverdisconnected event.

Implement the gattserverdisconnected event.

Specified at
https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-disconnect
and https://webbluetoothcg.github.io/web-bluetooth/#disconnection-events.

BUG=582537
Committed: https://crrev.com/91780826cccdef51542ac29eff5be5afa53f44ea
Cr-Commit-Position: refs/heads/master@{#394833}

[Jeffrey Yasskin, 2016-05-19 00:32:26]

jyasskin@chromium.org changed reviewers:
+ palmer@chromium.org, scheib@chromium.org

[Jeffrey Yasskin, 2016-05-19 00:32:27]

Vincent, please look at most of the CL.
Chris, please look at the mojom:
https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/public/p...

[Jeffrey Yasskin, 2016-05-19 00:32:32]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 00:33:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991063002/1

[scheib, 2016-05-19 01:26:57]

https://codereview.chromium.org/1991063002/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/1991063002/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:197:
//         - Request Disconnection Service - Getting characteristics will
It would add to boilerplate test code, but this device would seem more plausible
if e.g. there were a characteristic that when written to caused the disconnect.
It would also make test code a bit more readable: 
 getCharacteristic(kCauseDisconnectCharacteristicUUID)
 .then(char -> char.writeValue

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/bluetooth/connect/connect-disconnected-connect.html
(right):

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/connect/connect-disconnected-connect.html:20:
'Request is used for its side-effect.'),
Comment that 'getCharacteristics causes this device to disconnect'.

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp (right):

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp:68: LOG(ERROR)
<< "dispatching disconnected. Was connected? " << m_gatt->connected();
Did you intend to leave this?

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDevice.h
(right):

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDevice.h:14: //
Used to notify blink that the characteristic's value changed.
rewrite for this method, drop 'blink' if possible. Comment may not even be
needed.
// Notifies that the gatt server has been disconnected.

[commit-bot: I haz the power, 2016-05-19 02:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 02:42:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jeffrey Yasskin, 2016-05-19 17:46:23]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 17:46:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991063002/40001

[Jeffrey Yasskin, 2016-05-19 17:47:07]

https://codereview.chromium.org/1991063002/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/1991063002/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:197:
//         - Request Disconnection Service - Getting characteristics will
On 2016/05/19 01:26:57, scheib wrote:
> It would add to boilerplate test code, but this device would seem more
plausible
> if e.g. there were a characteristic that when written to caused the
disconnect.
> It would also make test code a bit more readable: 
>  getCharacteristic(kCauseDisconnectCharacteristicUUID)
>  .then(char -> char.writeValue 

Done.

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/bluetooth/connect/connect-disconnected-connect.html
(right):

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/connect/connect-disconnected-connect.html:20:
'Request is used for its side-effect.'),
On 2016/05/19 01:26:57, scheib wrote:
> Comment that 'getCharacteristics causes this device to disconnect'.

Done.

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp (right):

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp:68: LOG(ERROR)
<< "dispatching disconnected. Was connected? " << m_gatt->connected();
On 2016/05/19 01:26:57, scheib wrote:
> Did you intend to leave this?

Nope, removed. Thanks.

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDevice.h
(right):

https://codereview.chromium.org/1991063002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDevice.h:14: //
Used to notify blink that the characteristic's value changed.
On 2016/05/19 01:26:57, scheib wrote:
> rewrite for this method, drop 'blink' if possible. Comment may not even be
> needed.
> // Notifies that the gatt server has been disconnected.

Whoops, thanks. Yeah, I think the name of the method is probably explanatory
enough without the comment.

[scheib, 2016-05-19 17:59:16]

LGTM

[palmer, 2016-05-19 18:29:43]

lgtm

[Jeffrey Yasskin, 2016-05-19 18:31:44]

The CQ bit was unchecked by jyasskin@chromium.org

[Jeffrey Yasskin, 2016-05-19 18:31:49]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2016-05-19 18:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991063002/40001

[commit-bot: I haz the power, 2016-05-19 19:26:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-19 19:28:28]

Description was changed from

==========
Implement the gattserverdisconnected event.

Specified at
https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver...
and https://webbluetoothcg.github.io/web-bluetooth/#disconnection-events.

BUG=582537
==========

to

==========
Implement the gattserverdisconnected event.

Specified at
https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver...
and https://webbluetoothcg.github.io/web-bluetooth/#disconnection-events.

BUG=582537

Committed: https://crrev.com/91780826cccdef51542ac29eff5be5afa53f44ea
Cr-Commit-Position: refs/heads/master@{#394833}
==========

[commit-bot: I haz the power, 2016-05-19 19:28:30]

Patchset 3 (id:??) landed as
https://crrev.com/91780826cccdef51542ac29eff5be5afa53f44ea
Cr-Commit-Position: refs/heads/master@{#394833}