third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/disconnected_gc.html - Issue 1991063002: Implement the gattserverdisconnected event.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/disconnected_gc.html

Issue 1991063002: Implement the gattserverdisconnected event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename-web-bluetooth-device

Patch Set: Skip the new tests on Mac, where getCharacteristic isn't implemented yet. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/disconnected.html ('k') | third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/one-event-per-disconnection.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(t => {

	8 return setBluetoothFakeAdapter('DisconnectingHeartRateAdapter')

	9 .then(() => requestDeviceWithKeyDown({

	10 filters: [{services: ['heart_rate']}],

	11 optionalServices: [request_disconnection_service_uuid]

	12 }))

	13 .then(device => device.gatt.connect())

	14 .then(gattServer => gattServer.getPrimaryService(request_disconnection_servi ce_uuid))

	15 .then(service => service.getCharacteristic(request_disconnection_characteris tic_uuid))

	16 .then(requestDisconnection => {

	17 requestDisconnection.writeValue(new Uint8Array([0]));

	18 requestDisconnection = undefined;

	19 return runGarbageCollection();

	20 // Wait 50ms after the GC runs for the disconnection event to come back.

	21 // There's nothing to assert other than that only valid memory is used.

	22 }).then(() => new Promise(resolve => setTimeout(resolve, 50)));

	23 }, 'A device disconnecting after the BluetoothDevice object has been gced ' +

	24 'should not access freed memory.');

	25 </script>

OLD	NEW