Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1991033002: Make http/tests/media/audio-seekable-contains-zero-without-ranges.html work with multibuffers. (Closed)

Created:
4 years, 7 months ago by hubbe
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Make http/tests/media/audio-seekable-contains-zero-without-ranges.html work with multibuffers. This failed on windows with multibuffers. On all other platforms, the file is delivered immediately and the size is known, on windows it's a little slower, and we must remember to copy the size of the file when we reach the end. This behavior is a direct copy from buffered_data_source.cc, passes all tests so far and is unlikely to cause any problems. BUG=612546 Review-Url: https://codereview.chromium.org/1983793003 Cr-Commit-Position: refs/heads/master@{#394217} (cherry picked from commit 4d435e1e789fe2036570c608d024ba9bcbe64314) Committed: https://chromium.googlesource.com/chromium/src/+/5e1ea09a8a6027398e41445245943a9a786854be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M media/blink/multibuffer_data_source.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hubbe
4 years, 7 months ago (2016-05-18 23:22:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e1ea09a8a6027398e41445245943a9a786854be.

Powered by Google App Engine
This is Rietveld 408576698