Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1983793003: Make http/tests/media/audio-seekable-contains-zero-without-ranges.html work with multibuffers. (Closed)

Created:
4 years, 7 months ago by hubbe
Modified:
4 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make http/tests/media/audio-seekable-contains-zero-without-ranges.html work with multibuffers. This failed on windows with multibuffers. On all other platforms, the file is delivered immediately and the size is known, on windows it's a little slower, and we must remember to copy the size of the file when we reach the end. This behavior is a direct copy from buffered_data_source.cc, passes all tests so far and is unlikely to cause any problems. BUG=612546 Committed: https://crrev.com/4d435e1e789fe2036570c608d024ba9bcbe64314 Cr-Commit-Position: refs/heads/master@{#394217}

Patch Set 1 #

Patch Set 2 : test added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M media/blink/multibuffer_data_source.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hubbe
4 years, 7 months ago (2016-05-17 00:10:33 UTC) #2
DaleCurtis
Looks good. Can you add a unit test that fails on more platforms? :)
4 years, 7 months ago (2016-05-17 02:38:54 UTC) #3
hubbe
PTAL
4 years, 7 months ago (2016-05-17 18:38:47 UTC) #4
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-17 18:44:20 UTC) #5
DaleCurtis
This needs a BUG= in description for merging too.
4 years, 7 months ago (2016-05-17 18:44:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983793003/20001
4 years, 7 months ago (2016-05-17 19:17:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 20:35:35 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 20:37:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d435e1e789fe2036570c608d024ba9bcbe64314
Cr-Commit-Position: refs/heads/master@{#394217}

Powered by Google App Engine
This is Rietveld 408576698