Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 199093003: Merged r19798, r19896 into 3.24 branch. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r19798, r19896 into 3.24 branch. Fix bug in constant folding object comparisons. Correctly retain argument value when deopting from Math.round on x64. BUG=351624 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -41 lines) Patch
M src/hydrogen-instructions.h View 4 chunks +26 lines, -27 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-351624.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 9 months ago (2014-03-17 09:46:08 UTC) #1
Jakob Kummerow
lgtm
6 years, 9 months ago (2014-03-17 09:48:44 UTC) #2
Yang
6 years, 9 months ago (2014-03-17 09:49:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19970.

Powered by Google App Engine
This is Rietveld 408576698