Issue 19909002: Revert 212719 "Copy mini_installer_exe_version.rc to PRODUCT_DIR"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19909002: Revert 212719 "Copy mini_installer_exe_version.rc to PRODUCT_DIR" (Closed)

Created:
7 years, 5 months ago by kareng

Modified:
7 years, 5 months ago

Reviewers:
jschuh

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1571/src/

Visibility:
Public.

Revert 212719 "Copy mini_installer_exe_version.rc to PRODUCT_DIR" > Copy mini_installer_exe_version.rc to PRODUCT_DIR > > This is needed to fix hardcoded paths in FILES.CFG that > prevent using ninja for official builds. > > BUG=262193 > R=grt@chromium.org, mmoss@chromium.org > > Review URL: https://codereview.chromium.org/19845002 TBR=jschuh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212819

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -13 lines)			Patch
	M	chrome/installer/mini_installer.gyp	View		1 chunk	+0 lines, -12 lines	0 comments	Download
	M	chrome/tools/build/win/FILES.cfg	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r212819.