Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5185)

Unified Diff: chrome/installer/mini_installer.gyp

Issue 19909002: Revert 212719 "Copy mini_installer_exe_version.rc to PRODUCT_DIR" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1571/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/build/win/FILES.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer.gyp
===================================================================
--- chrome/installer/mini_installer.gyp (revision 212818)
+++ chrome/installer/mini_installer.gyp (working copy)
@@ -146,18 +146,6 @@
'message': 'Generating version information'
},
],
- # Copy the version file to a known location for FILES.cfg
- # TODO(jschuh): crbug.com/262193 Remove this copy and output
- # directly to PRODUCT_DIR when the official builders are
- # verified to not need the intermediate location.
- 'copies': [
- {
- 'destination': '<(PRODUCT_DIR)',
- 'files': [
- '<(INTERMEDIATE_DIR)/mini_installer_exe_version.rc',
- ],
- },
- ],
# TODO(mark): <(branding_dir) should be defined by the
# global condition block at the bottom of the file, but
# this doesn't work due to the following issue:
« no previous file with comments | « no previous file | chrome/tools/build/win/FILES.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698