Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1990793003:
Don't allow uncacheable paths in tessellated path renderer (Closed)
DescriptionDon't allow uncacheable paths in tessellated path renderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1990793003
Committed: https://skia.googlesource.com/skia/+/aebd0fd32f8fde610de03b4f1e6d11ce24bfb73d
Patch Set 1 #
Total comments: 2
Patch Set 2 : Change order of tests in onCanDrawPath #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Don't allow uncacheable paths in tessellated path renderer ========== to ========== Don't allow uncacheable paths in tessellated path renderer GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
bsalomon@google.com changed reviewers: + senorblanco@google.com
Stephen, I think this addresses your concern from the GrStrokeInfo->GrStyle change. The other case when the key can't be computed is if the original path is volatile, which GrStyle doesn't know. The next step in this evolution is to replace path+style with GrShape which is a path (or rrect) with a GrStyle. Since it knows the geometry and the styling information it will know whether a key can be computed.
senorblanco@chromium.org changed reviewers: + senorblanco@chromium.org
LGTM w/nit Thanks for this! https://codereview.chromium.org/1990793003/diff/1/src/gpu/batches/GrTessellat... File src/gpu/batches/GrTessellatingPathRenderer.cpp (right): https://codereview.chromium.org/1990793003/diff/1/src/gpu/batches/GrTessellat... src/gpu/batches/GrTessellatingPathRenderer.cpp:114: !args.fPath->isVolatile(); Could you put this ahead of the other tests? (Various reasons...)
https://codereview.chromium.org/1990793003/diff/1/src/gpu/batches/GrTessellat... File src/gpu/batches/GrTessellatingPathRenderer.cpp (right): https://codereview.chromium.org/1990793003/diff/1/src/gpu/batches/GrTessellat... src/gpu/batches/GrTessellatingPathRenderer.cpp:114: !args.fPath->isVolatile(); On 2016/05/18 13:45:49, Stephen White wrote: > Could you put this ahead of the other tests? (Various reasons...) Because it is a fast check, right? I reordered them based on my guess of relative costs in patchset 2.
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990793003/20001
On 2016/05/18 13:53:44, bsalomon wrote: > https://codereview.chromium.org/1990793003/diff/1/src/gpu/batches/GrTessellat... > File src/gpu/batches/GrTessellatingPathRenderer.cpp (right): > > https://codereview.chromium.org/1990793003/diff/1/src/gpu/batches/GrTessellat... > src/gpu/batches/GrTessellatingPathRenderer.cpp:114: !args.fPath->isVolatile(); > On 2016/05/18 13:45:49, Stephen White wrote: > > Could you put this ahead of the other tests? (Various reasons...) > > Because it is a fast check, right? I reordered them based on my guess of > relative costs in patchset 2. Great, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/1990793003/#ps20001 (title: "Change order of tests in onCanDrawPath")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990793003/20001
Message was sent while issue was closed.
Description was changed from ========== Don't allow uncacheable paths in tessellated path renderer GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Don't allow uncacheable paths in tessellated path renderer GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/aebd0fd32f8fde610de03b4f1e6d11ce24bfb73d ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/aebd0fd32f8fde610de03b4f1e6d11ce24bfb73d
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1993923002/ by bsalomon@google.com. The reason for reverting is: Caused innershapes test to be rendered incorrectly on the N10. This might be a driver bug.. |
