Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1990763003: Actually unship --intl_extra (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
jungshik at Google
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Actually unship --intl_extra The default value of the flag was true, so --intl_extra was not previously unshipped. This patch sets it to false. BUG=v8:3785 CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng Committed: https://crrev.com/7517f8776df0bd42ca8e09b0f414594c02adf549 Cr-Commit-Position: refs/heads/master@{#36346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990763003/1
4 years, 7 months ago (2016-05-19 00:31:28 UTC) #3
Dan Ehrenberg
4 years, 7 months ago (2016-05-19 00:31:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 01:08:31 UTC) #6
jungshik at Google
lgtm
4 years, 7 months ago (2016-05-19 06:40:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990763003/1
4 years, 7 months ago (2016-05-19 06:41:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 06:42:49 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 06:44:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7517f8776df0bd42ca8e09b0f414594c02adf549
Cr-Commit-Position: refs/heads/master@{#36346}

Powered by Google App Engine
This is Rietveld 408576698