src/flag-definitions.h - Issue 1990763003: Actually unship --intl_extra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 1990763003: Actually unship --intl_extra (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index 8c330b3a1f41c466119e0399474d2e7dd9bf9608..e7d75c48ffcb457b9f66d215061b413833417751 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -188,7 +188,7 @@ DEFINE_BOOL(promise_extra, false, "additional V8 Promise functions")

// Removing extra Promise functions is shipped

DEFINE_NEG_VALUE_IMPLICATION(harmony_shipping, promise_extra, true)

-DEFINE_BOOL(intl_extra, true, "additional V8 Intl functions")

+DEFINE_BOOL(intl_extra, false, "additional V8 Intl functions")

// Removing extra Intl functions is shipped

DEFINE_NEG_VALUE_IMPLICATION(harmony_shipping, intl_extra, true)

« no previous file with comments | « no previous file | no next file » | no next file with comments »