Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3714)

Unified Diff: blimp/engine/app/blimp_engine_crash_reporter_client.cc

Issue 1990723002: Add a compile time flag to only upload crash symbols for official builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ::shamecube:: Remove silly debug file Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/engine/BUILD.gn ('K') | « blimp/engine/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/app/blimp_engine_crash_reporter_client.cc
diff --git a/blimp/engine/app/blimp_engine_crash_reporter_client.cc b/blimp/engine/app/blimp_engine_crash_reporter_client.cc
index e9b026c220ea0965d6dd9706c888d972724c0686..7a80f6b20bc6759e5eb181200c55dd304e54490c 100644
--- a/blimp/engine/app/blimp_engine_crash_reporter_client.cc
+++ b/blimp/engine/app/blimp_engine_crash_reporter_client.cc
@@ -45,8 +45,12 @@ bool BlimpEngineCrashReporterClient::IsRunningUnattended() {
}
bool BlimpEngineCrashReporterClient::GetCollectStatsConsent() {
- // Always collect Blimp engine crash reports.
+ // Always collect Blimp engine crash reports on official builds
Kevin M 2016/05/18 16:46:42 Add a trailing dot.
marcinjb 2016/05/18 17:39:24 Done.
+#ifdef OFFICIAL_BLIMP_BUILD
return true;
+#else
+ return false;
+#endif // OFFICIAL_BLIMP_BUILD
}
bool BlimpEngineCrashReporterClient::EnableBreakpadForProcess(
« blimp/engine/BUILD.gn ('K') | « blimp/engine/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698