Add a compile time flag to only upload crash symbols for official builds

blimp/engine/BUILD.gn

Index: blimp/engine/BUILD.gn
diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn
index 1805e8424a9b6e61860b571a6957cdcd77874022..1d8d0a9e47365acfc068d91364c2d24ca3d9420a 100644
--- a/blimp/engine/BUILD.gn
+++ b/blimp/engine/BUILD.gn
@@ -46,6 +46,15 @@ repack("pak") {
   output = "$root_out_dir/blimp_engine.pak"
 }
 
+# Config for defining compile-time official build flags.
+config("official_build_config") {
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  defines = []

[Kevin M, 2016/05/18 16:46:42]

Why are we zapping the defines? Wouldn't this throw away beneficial defines like
NDEBUG, OS_XYZ, etc.?

[marcinjb, 2016/05/18 17:39:24]

Obsolete, however if I didn't have this here, I'd get yelled at with about the
line below saying "can't append to something that isn't there."  Weird...

+  if (is_official_build) {
+    defines += [ "OFFICIAL_BLIMP_BUILD" ]

[Kevin M, 2016/05/18 16:46:42]

Dumb question, but why can't we use the OFFICIAL_BUILD define instead?

[marcinjb, 2016/05/18 17:39:24]

Because I was dumb and missed OFFICIAL_BUILD in features.gni.

+  }
+}
+
 source_set("app") {
   sources = [
     "app/blimp_browser_main_parts.cc",
@@ -218,6 +227,8 @@ source_set("crash") {
     "//components/version_info:generate_version_info",
     "//content/public/common",
   ]
+
+  configs += [ ":official_build_config" ]
 }
 
 source_set("common") {