Issue 1990463002: Skip SDK summaries in the presence of SDK extenders (#26448).

Issue 1990463002: Skip SDK summaries in the presence of SDK extenders (#26448). (Closed)

Created:
4 years, 7 months ago by pquitslund

Modified:
4 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, Paul Berry

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Skip SDK summaries in the presence of SDK extenders (#26448). Works around crash provoked by mojo: https://github.com/dart-lang/sdk/issues/26448. The rub is that using SDK summaries in the presence of SDK extenders (and embedders) is unsafe. Greater context: https://github.com/dart-lang/sdk/issues/26467. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/31a03ec31b1dc1c7db8b6cecd61fbca746766a73

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -35 lines)			Patch
M	pkg/analyzer_cli/lib/src/driver.dart	View	5 chunks	+31 lines, -14 lines	0 comments	Download
M	pkg/analyzer_cli/test/all.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer_cli/test/sdk_ext_test.dart	View	1 chunk	+12 lines, -19 lines	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

4 years, 7 months ago (2016-05-17 18:10:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
31a03ec31b1dc1c7db8b6cecd61fbca746766a73 (presubmit successful).