Skip SDK summaries in the presence of SDK extenders (#26448).

pkg/analyzer_cli/lib/src/driver.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.driver;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
@@ skipping 334 matching lines @@
           EmbedderUriResolver embedderUriResolver =
               embeddedUriResolverProvider(folder);
           if (embedderUriResolver != null && embedderUriResolver.length != 0) {
             sdkResolver = embedderUriResolver;
           }
         }
 
         // Default to a Dart URI resolver if no embedder is found.
         sdkResolver ??= new DartUriResolver(sdk);
 
-        // TODO(brianwilkerson) This doesn't sdk extensions.
+        // TODO(brianwilkerson) This doesn't handle sdk extensions.
         List<UriResolver> resolvers = <UriResolver>[
           sdkResolver,
           resolver,
           new FileUriResolver()
         ];
         return new SourceFactory(resolvers);
       }
     }
 
     UriResolver packageUriResolver;
@@ skipping 122 matching lines @@
       contextOptions.analyzeFunctionBodiesPredicate = dietParsingPolicy;
     });
 
     // Find package info.
     _PackageInfo packageInfo = _findPackages(options);
 
     // Process embedders.
     Map<fileSystem.Folder, YamlMap> embedderMap =
         _findEmbedders(packageInfo.packageMap);
 
+    // Scan for SDK extenders.
+    bool hasSdkExt = _hasSdkExt(packageInfo.packageMap?.values);
+
+    // No summaries in the presence of embedders or extenders.
+    bool useSummaries = embedderMap.isEmpty && !hasSdkExt;
+
     // Once options and embedders are processed, setup the SDK.
-    _setupSdk(options, embedderMap.isNotEmpty);
+    _setupSdk(options, useSummaries);
 
     // Choose a package resolution policy and a diet parsing policy based on
     // the command-line options.
     SourceFactory sourceFactory =
         _chooseUriResolutionPolicy(options, embedderMap, packageInfo);
 
     _context.sourceFactory = sourceFactory;
   }
 
   /// Return discovered packagespec, or `null` if none is found.
@@ skipping 62 matching lines @@
     Map<String, List<fileSystem.Folder>> folderMap =
         new Map<String, List<fileSystem.Folder>>();
     packages.asMap().forEach((String packagePath, Uri uri) {
       folderMap[packagePath] = [
         PhysicalResourceProvider.INSTANCE.getFolder(path.fromUri(uri))
       ];
     });
     return folderMap;
   }
 
+  bool _hasSdkExt(Iterable<List<fileSystem.Folder>> folders) {
+    if (folders != null) {
+      //TODO: ideally share this traversal with SdkExtUriResolver
+      for (Iterable<fileSystem.Folder> libDirs in folders) {
+        if (libDirs.any((fileSystem.Folder libDir) =>
+        libDir
+            .getChild(SdkExtUriResolver.SDK_EXT_NAME)
+            .exists)) {
+          return true;
+        }
+      }
+    }
+    return false;
+  }
+
   /// Returns `true` if this relative path is a hidden directory.
   bool _isInHiddenDir(String relative) =>
       path.split(relative).any((part) => part.startsWith("."));
 
   void _processPlugins() {
     List<Plugin> plugins = <Plugin>[];
     plugins.addAll(AnalysisEngine.instance.requiredPlugins);
     plugins.add(AnalysisEngine.instance.commandLinePlugin);
     plugins.add(AnalysisEngine.instance.optionsPlugin);
     plugins.add(linterPlugin);
@@ skipping 11 matching lines @@
     var errorSeverity = analyzer.analyzeSync();
     if (errorSeverity == ErrorSeverity.ERROR) {
       exitCode = errorSeverity.ordinal;
     }
     if (options.warningsAreFatal && errorSeverity == ErrorSeverity.WARNING) {
       exitCode = errorSeverity.ordinal;
     }
     return errorSeverity;
   }
 
-  void _setupSdk(CommandLineOptions options, bool hasEmbedder) {
+  void _setupSdk(CommandLineOptions options, bool useSummaries) {
     if (sdk == null) {
       if (options.dartSdkSummaryPath != null) {
         sdk = new SummaryBasedDartSdk(
             options.dartSdkSummaryPath, options.strongMode);
       } else {
         String dartSdkPath = options.dartSdkPath;
         DirectoryBasedDartSdk directorySdk =
             new DirectoryBasedDartSdk(new JavaFile(dartSdkPath));
-        // Summaries are disabled in the presence of embedders.
-        if (hasEmbedder) {
-          directorySdk.useSummary = false;
-        } else {
-          directorySdk.useSummary =
-              options.sourceFiles.every((String sourcePath) {
-            sourcePath = path.absolute(sourcePath);
-            sourcePath = path.normalize(sourcePath);
-            return !path.isWithin(dartSdkPath, sourcePath);
-          });
-        }
+        directorySdk.useSummary = useSummaries &&
+            options.sourceFiles.every((String sourcePath) {
+              sourcePath = path.absolute(sourcePath);
+              sourcePath = path.normalize(sourcePath);
+              return !path.isWithin(dartSdkPath, sourcePath);
+            });
+
         directorySdk.analysisOptions = context.analysisOptions;
         sdk = directorySdk;
       }
     }
   }
 
   static AnalysisOptionsImpl createAnalysisOptionsForCommandLineOptions(
       CommandLineOptions options) {
     AnalysisOptionsImpl contextOptions = new AnalysisOptionsImpl();
     contextOptions.hint = !options.disableHints;
@@ skipping 187 matching lines @@
     for (var package in packages) {
       var packageName = path.basename(package.path);
       var realPath = package.resolveSymbolicLinksSync();
       result[packageName] = [
         PhysicalResourceProvider.INSTANCE.getFolder(realPath)
       ];
     }
     return result;
   }
 }