Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1990323002: [Media Router WebUI] Handle route details in incognito. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Handle route details in incognito. While we currently don't support split mode for the extension, we cannot do any toplevel navigations with the component extension with extensionview. Thus, anyone trying to view the route details in incognito mode will see a "This site can't be reached" error message if there was custom controls available for the route. This change only shows the default route details description when the browser is "off the record", aka in incognito mode. BUG=604407 Review URL: https://codereview.chromium.org/1898953002 Cr-Commit-Position: refs/heads/master@{#388107} (cherry picked from commit 34b4be50fde0e4a79798bab28a47acbadc0e6479) Committed: https://chromium.googlesource.com/chromium/src/+/cc5cecb07d9c63295e0f42a1c622836855a19d32

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
apacible
4 years, 7 months ago (2016-05-19 16:20:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc5cecb07d9c63295e0f42a1c622836855a19d32.

Powered by Google App Engine
This is Rietveld 408576698