[Media Router WebUI] Handle route details in incognito.

[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any toplevel navigations with the component extension with extensionview. Thus, anyone trying to view the route details in incognito mode will see a "This site can't be reached" error message if there was custom controls available for the route.

This change only shows the default route details description when the browser is "off the record", aka in incognito mode.

BUG=604407
Committed: https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479
Cr-Commit-Position: refs/heads/master@{#388107}

[apacible, 2016-04-18 20:56:53]

Description was changed from

==========
asdf

BUG=
==========

to

==========
[Media Router WebUI] Handle route details in incognito.

BUG=604407
==========

[apacible, 2016-04-18 21:01:04]

Patchset #1 (id:1) has been deleted

[apacible, 2016-04-18 21:07:40]

Description was changed from

==========
[Media Router WebUI] Handle route details in incognito.

BUG=604407
==========

to

==========
[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any
toplevel navigations with the component extension with extensionview. Thus,
anyone trying to view the route details in incognito mode will see a "This site
can't be reached" error message if there was custom controls available for the
route.

This change only shows the default route details description when the browser is
"off the record", aka in incognito mode.

BUG=604407
==========

[apacible, 2016-04-18 21:07:40]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-04-18 21:08:01]

Patchset #1 (id:20001) has been deleted

[apacible, 2016-04-18 21:08:30]

PTAL, thanks!

[apacible, 2016-04-18 21:10:14]

Screenshot:
https://screenshot.googleplex.com/Xw0p7avjyWq.png

[imcheng, 2016-04-18 23:45:43]

lgtm

[mark a. foltz, 2016-04-18 23:49:37]

mfoltz@chromium.org changed reviewers:
+ mfoltz@chromium.org

[mark a. foltz, 2016-04-18 23:49:38]

Probably good to fix this here, but I was also going to patch the Cast MRP to
not set the custom controller URL for OTR routes.

[apacible, 2016-04-19 01:07:41]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2016-04-19 01:08:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898953002/40001

[commit-bot: I haz the power, 2016-04-19 01:14:23]

Description was changed from

==========
[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any
toplevel navigations with the component extension with extensionview. Thus,
anyone trying to view the route details in incognito mode will see a "This site
can't be reached" error message if there was custom controls available for the
route.

This change only shows the default route details description when the browser is
"off the record", aka in incognito mode.

BUG=604407
==========

to

==========
[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any
toplevel navigations with the component extension with extensionview. Thus,
anyone trying to view the route details in incognito mode will see a "This site
can't be reached" error message if there was custom controls available for the
route.

This change only shows the default route details description when the browser is
"off the record", aka in incognito mode.

BUG=604407
==========

[commit-bot: I haz the power, 2016-04-19 01:14:23]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-04-19 01:15:49]

Description was changed from

==========
[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any
toplevel navigations with the component extension with extensionview. Thus,
anyone trying to view the route details in incognito mode will see a "This site
can't be reached" error message if there was custom controls available for the
route.

This change only shows the default route details description when the browser is
"off the record", aka in incognito mode.

BUG=604407
==========

to

==========
[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any
toplevel navigations with the component extension with extensionview. Thus,
anyone trying to view the route details in incognito mode will see a "This site
can't be reached" error message if there was custom controls available for the
route.

This change only shows the default route details description when the browser is
"off the record", aka in incognito mode.

BUG=604407

Committed: https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479
Cr-Commit-Position: refs/heads/master@{#388107}
==========

[commit-bot: I haz the power, 2016-04-19 01:15:50]

Patchset 1 (id:??) landed as
https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479
Cr-Commit-Position: refs/heads/master@{#388107}

[apacible, 2016-04-19 01:21:19]

On 2016/04/18 23:49:38, mark a. foltz wrote:
> Probably good to fix this here, but I was also going to patch the Cast MRP to
> not set the custom controller URL for OTR routes.

Thanks, I'll get this merged into M51 as well.

[mark a. foltz, 2016-04-19 18:24:24]

lgtm with a bikeshed on names.

https://codereview.chromium.org/1898953002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
(right):

https://codereview.chromium.org/1898953002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc:413:
initial_data.SetBoolean("isOffTheRecord", profile->IsOffTheRecord());
There is already a per-route boolean that indicates whether the route is off the
record.  To avoid confusion between this value and the per-route value, I might
have named it "isIncognitoProfile"...

But I really don't think it's worth spending time on a patch for this change.