Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1990313002: Split Media.Controls.Show in .Video and .Audio. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add more comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index beaa552e9f848587003ddddedf1e9eed40648ca9..49510d9502305229be05390e028b7dc326b32beb 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -2176,29 +2176,27 @@ void HTMLMediaElement::setLoop(bool b)
bool HTMLMediaElement::shouldShowControls(const RecordMetricsBehavior recordMetrics) const
{
- DEFINE_STATIC_LOCAL(EnumerationHistogram, showControlsHistogram, ("Media.Controls.Show", MediaControlsShowMax));
-
if (fastHasAttribute(controlsAttr)) {
if (recordMetrics == RecordMetricsBehavior::DoRecord)
- showControlsHistogram.count(MediaControlsShowAttribute);
+ showControlsHistogram().count(MediaControlsShowAttribute);
return true;
}
if (isFullscreen()) {
if (recordMetrics == RecordMetricsBehavior::DoRecord)
- showControlsHistogram.count(MediaControlsShowFullscreen);
+ showControlsHistogram().count(MediaControlsShowFullscreen);
return true;
}
LocalFrame* frame = document().frame();
if (frame && !frame->script().canExecuteScripts(NotAboutToExecuteScript)) {
if (recordMetrics == RecordMetricsBehavior::DoRecord)
- showControlsHistogram.count(MediaControlsShowNoScript);
+ showControlsHistogram().count(MediaControlsShowNoScript);
return true;
}
if (recordMetrics == RecordMetricsBehavior::DoRecord)
- showControlsHistogram.count(MediaControlsShowNotShown);
+ showControlsHistogram().count(MediaControlsShowNotShown);
return false;
}
@@ -3756,6 +3754,17 @@ void HTMLMediaElement::rejectPlayPromises(ExceptionCode code, const String& mess
m_playResolvers.clear();
}
+EnumerationHistogram& HTMLMediaElement::showControlsHistogram() const
+{
+ if (isHTMLVideoElement()) {
+ DEFINE_STATIC_LOCAL(EnumerationHistogram, histogram, ("Media.Controls.Show.Video", MediaControlsShowMax));
+ return histogram;
+ }
+
+ DEFINE_STATIC_LOCAL(EnumerationHistogram, histogram, ("Media.Controls.Show.Audio", MediaControlsShowMax));
+ return histogram;
+}
+
void HTMLMediaElement::clearWeakMembers(Visitor* visitor)
{
if (!ThreadHeap::isHeapObjectAlive(m_audioSourceNode)) {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698