Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1990183002: [serializer] do not cache resource data pointer for native source. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] do not cache resource data pointer for native source. The cached resource data pointer is a source of non-determinism when creating the snapshot. Long-term we may not keep the native source in memory anyways, so caching the resource data pointer will not be possible. R=ulan@chromium.org BUG=v8:4886 LOG=N Committed: https://crrev.com/28df32d908259ccc2c6881ee6c7f4a44f3ca304c Cr-Commit-Position: refs/heads/master@{#36361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -31 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/snapshot/natives.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/snapshot/natives-common.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/snapshot/serializer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-05-19 07:59:43 UTC) #1
ulan
lgtm
4 years, 7 months ago (2016-05-19 11:03:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990183002/1
4 years, 7 months ago (2016-05-19 11:47:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 12:28:37 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 12:29:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28df32d908259ccc2c6881ee6c7f4a44f3ca304c
Cr-Commit-Position: refs/heads/master@{#36361}

Powered by Google App Engine
This is Rietveld 408576698