Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/snapshot/serializer.cc

Issue 1990183002: [serializer] do not cache resource data pointer for native source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/snapshot/natives-common.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/snapshot/serializer.h" 5 #include "src/snapshot/serializer.h"
6 6
7 #include "src/macro-assembler.h" 7 #include "src/macro-assembler.h"
8 #include "src/snapshot/natives.h" 8 #include "src/snapshot/natives.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 bytes_processed_so_far_ += sizeof(resource); 680 bytes_processed_so_far_ += sizeof(resource);
681 return true; 681 return true;
682 } 682 }
683 } 683 }
684 } 684 }
685 return false; 685 return false;
686 } 686 }
687 687
688 void Serializer::ObjectSerializer::VisitExternalOneByteString( 688 void Serializer::ObjectSerializer::VisitExternalOneByteString(
689 v8::String::ExternalOneByteStringResource** resource_pointer) { 689 v8::String::ExternalOneByteStringResource** resource_pointer) {
690 DCHECK_EQ(serializer_->isolate()->heap()->native_source_string_map(),
691 object_->map());
692 DCHECK(ExternalOneByteString::cast(object_)->is_short());
690 Address references_start = reinterpret_cast<Address>(resource_pointer); 693 Address references_start = reinterpret_cast<Address>(resource_pointer);
691 OutputRawData(references_start); 694 OutputRawData(references_start);
692 if (SerializeExternalNativeSourceString( 695 if (SerializeExternalNativeSourceString(
693 Natives::GetBuiltinsCount(), resource_pointer, 696 Natives::GetBuiltinsCount(), resource_pointer,
694 Natives::GetSourceCache(serializer_->isolate()->heap()), 697 Natives::GetSourceCache(serializer_->isolate()->heap()),
695 kNativesStringResource)) { 698 kNativesStringResource)) {
696 return; 699 return;
697 } 700 }
698 if (SerializeExternalNativeSourceString( 701 if (SerializeExternalNativeSourceString(
699 ExtraNatives::GetBuiltinsCount(), resource_pointer, 702 ExtraNatives::GetBuiltinsCount(), resource_pointer,
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
769 if (to_skip != 0 && return_skip == kIgnoringReturn) { 772 if (to_skip != 0 && return_skip == kIgnoringReturn) {
770 sink_->Put(kSkip, "Skip"); 773 sink_->Put(kSkip, "Skip");
771 sink_->PutInt(to_skip, "SkipDistance"); 774 sink_->PutInt(to_skip, "SkipDistance");
772 to_skip = 0; 775 to_skip = 0;
773 } 776 }
774 return to_skip; 777 return to_skip;
775 } 778 }
776 779
777 } // namespace internal 780 } // namespace internal
778 } // namespace v8 781 } // namespace v8
OLDNEW
« no previous file with comments | « src/snapshot/natives-common.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698