Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1990173002: Fix "unused variable" warnings. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "unused variable" warnings. These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and must be fixed before that change can land. See https://codereview.chromium.org/1981053002/ for the full CL. BUG=447156 TEST=none Committed: https://crrev.com/9d32759613f098ea04b62ad4f7bd7ef3413a3265 Cr-Commit-Position: refs/heads/master@{#394834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M extensions/browser/api/hid/hid_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.h View 3 chunks +2 lines, -8 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/request_sender.h View 3 chunks +1 line, -3 lines 0 comments Download
M extensions/renderer/request_sender.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
4 years, 7 months ago (2016-05-19 07:19:44 UTC) #2
asargent_no_longer_on_chrome
lgtm
4 years, 7 months ago (2016-05-19 19:03:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990173002/1
4 years, 7 months ago (2016-05-19 19:30:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 19:37:29 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 19:38:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d32759613f098ea04b62ad4f7bd7ef3413a3265
Cr-Commit-Position: refs/heads/master@{#394834}

Powered by Google App Engine
This is Rietveld 408576698