Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issue 1990133002: X87: Add cmpxchg and lock instructions to x64 and ia32 {dis,}assemblers. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Add cmpxchg and lock instructions to x64 and ia32 {dis,}assemblers. port 5c22cf5ae7a7989669a363f783f9bd625bdacec5 (r36341) original commit message: BUG= Committed: https://crrev.com/9cf93e1c6d1d741ae18b9ea2189cf19802cddca7 Cr-Commit-Position: refs/heads/master@{#36345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M src/x87/assembler-x87.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M src/x87/disasm-x87.cc View 5 chunks +30 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-19 05:19:00 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-19 05:29:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990133002/1
4 years, 7 months ago (2016-05-19 05:33:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 05:55:32 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 05:59:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cf93e1c6d1d741ae18b9ea2189cf19802cddca7
Cr-Commit-Position: refs/heads/master@{#36345}

Powered by Google App Engine
This is Rietveld 408576698