Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 199013002: Correctly retain argument value when deopting from Math.round on x64. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Correctly retain argument value when deopting from Math.round on x64. R=jkummerow@chromium.org BUG=351624 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19896

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M src/x64/lithium-codegen-x64.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-351624.js View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-13 12:45:25 UTC) #1
Jakob Kummerow
LGTM with nits. Thanks! https://codereview.chromium.org/199013002/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/199013002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3611 src/x64/lithium-codegen-x64.cc:3611: Label done, round_to_zero, below_one_half, do_not_compensate, ...
6 years, 9 months ago (2014-03-13 12:50:00 UTC) #2
Yang
Committed patchset #2 manually as r19896 (presubmit successful).
6 years, 9 months ago (2014-03-13 13:57:30 UTC) #3
Yang
6 years, 9 months ago (2014-03-13 13:58:00 UTC) #4
Message was sent while issue was closed.
On 2014/03/13 13:57:30, Yang wrote:
> Committed patchset #2 manually as r19896 (presubmit successful).

Thanks for the comments. Addressed.

Powered by Google App Engine
This is Rietveld 408576698