Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 199013002: Correctly retain argument value when deopting from Math.round on x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/regress/regress-351624.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1115 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 1126
1127 1127
1128 LInstruction* LChunkBuilder::DoMathFloor(HUnaryMathOperation* instr) { 1128 LInstruction* LChunkBuilder::DoMathFloor(HUnaryMathOperation* instr) {
1129 LOperand* input = UseRegisterAtStart(instr->value()); 1129 LOperand* input = UseRegisterAtStart(instr->value());
1130 LMathFloor* result = new(zone()) LMathFloor(input); 1130 LMathFloor* result = new(zone()) LMathFloor(input);
1131 return AssignEnvironment(DefineAsRegister(result)); 1131 return AssignEnvironment(DefineAsRegister(result));
1132 } 1132 }
1133 1133
1134 1134
1135 LInstruction* LChunkBuilder::DoMathRound(HUnaryMathOperation* instr) { 1135 LInstruction* LChunkBuilder::DoMathRound(HUnaryMathOperation* instr) {
1136 LOperand* input = UseRegisterAtStart(instr->value()); 1136 LOperand* input = UseRegister(instr->value());
1137 LMathRound* result = new(zone()) LMathRound(input); 1137 LOperand* temp = FixedTemp(xmm4);
1138 LMathRound* result = new(zone()) LMathRound(input, temp);
1138 return AssignEnvironment(DefineAsRegister(result)); 1139 return AssignEnvironment(DefineAsRegister(result));
1139 } 1140 }
1140 1141
1141 1142
1142 LInstruction* LChunkBuilder::DoMathAbs(HUnaryMathOperation* instr) { 1143 LInstruction* LChunkBuilder::DoMathAbs(HUnaryMathOperation* instr) {
1143 LOperand* context = UseAny(instr->context()); 1144 LOperand* context = UseAny(instr->context());
1144 LOperand* input = UseRegisterAtStart(instr->value()); 1145 LOperand* input = UseRegisterAtStart(instr->value());
1145 LMathAbs* result = new(zone()) LMathAbs(context, input); 1146 LMathAbs* result = new(zone()) LMathAbs(context, input);
1146 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 1147 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
1147 } 1148 }
(...skipping 1372 matching lines...) Expand 10 before | Expand all | Expand 10 after
2520 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2521 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2521 LOperand* object = UseRegister(instr->object()); 2522 LOperand* object = UseRegister(instr->object());
2522 LOperand* index = UseTempRegister(instr->index()); 2523 LOperand* index = UseTempRegister(instr->index());
2523 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2524 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2524 } 2525 }
2525 2526
2526 2527
2527 } } // namespace v8::internal 2528 } } // namespace v8::internal
2528 2529
2529 #endif // V8_TARGET_ARCH_X64 2530 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/regress/regress-351624.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698