Move bindToCurrentThread out to the creators of WebGL contexts.

Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
TBR=pfeldman
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/f07993965cc4250d01226f5260736608957e91d8
Cr-Commit-Position: refs/heads/master@{#394877}

[danakj, 2016-05-19 00:48:34]

Description was changed from

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
BUG=487471
==========

to

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-05-19 00:48:42]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 00:49:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990063004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990063004/1

[danakj, 2016-05-19 00:59:45]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 01:00:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990063004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990063004/20001

[danakj, 2016-05-19 01:06:59]

https://codereview.chromium.org/1990063004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/1990063004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:530:
errorString.insert("bindToCurrentThread failed: ", 0);
This string was inserted if bindToCurrentThread failed, and we only got here if
bind failed (other than the shouldFailContextCreationForTesting thing). So I
just moved this string modification to the last minute here instead of changing
the GLInfo. I could do it at the callsite of this if you prefer.

https://codereview.chromium.org/1990063004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:536:
struct ContextProviderCreationInfo {
I made this into just a struct, less lines of code.

https://codereview.chromium.org/1990063004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:581:
contextProvider = createContextProviderOnWorkerThread(contextAttributes,
&glInfo, scriptState);
We were making a new glInfo on the main thread, which means the worker thread
wasn't seeing what the creation code actually set on the glInfo. I made the
thread hoppping all use a pointer to the glInfo instead.

https://codereview.chromium.org/1990063004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:583: if
(!contextProvider->bindToCurrentThread() || shouldFailContextCreationForTesting)
{
The provider will never be null now, but bind can fail.

https://codereview.chromium.org/1990063004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h (left):

https://codereview.chromium.org/1990063004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:1092: class
ContextProviderCreationInfo;
I made these all local to the cpp file since they don't need to access stuff on
the WebGLRCBase class.

[danakj, 2016-05-19 01:07:28]

danakj@chromium.org changed reviewers:
+ chrishtr@chromium.org, pfeldman@chromium.org, piman@chromium.org

[danakj, 2016-05-19 01:07:29]

+piman for content/
+chrishtr for public/
+pfeldman for test_runner (will TBR)

[danakj, 2016-05-19 01:07:39]

Description was changed from

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
TBR=pfeldman
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-05-19 01:07:43]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 01:08:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990063004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990063004/40001

[piman, 2016-05-19 01:45:35]

lgtm

[Ken Russell (switch to Gerrit), 2016-05-19 02:01:30]

lgtm

[commit-bot: I haz the power, 2016-05-19 03:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 03:30:47]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2016-05-19 18:44:18]

https://codereview.chromium.org/1990063004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/1990063004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:583: if
(!contextProvider->bindToCurrentThread() || shouldFailContextCreationForTesting)
{
Oh, slight lie here. While making a ContextProvider::Factory can't fail the
createOffscreenContext function can - if the channel can't be established, or
the context is DOA. Will have to nullcheck here, and move the "bind failed"
prepend to a separate branch here.

[danakj, 2016-05-19 19:00:52]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-05-19 19:00:53]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1990063004/#ps80001
(title: "bindwebgl: .")

[commit-bot: I haz the power, 2016-05-19 19:01:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990063004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990063004/80001

[commit-bot: I haz the power, 2016-05-19 20:12:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 20:12:37]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-05-19 20:28:31]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-05-19 20:28:48]

On 2016/05/19 20:12:37, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

TOT looks mildly broken, let's try again.

[commit-bot: I haz the power, 2016-05-19 20:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990063004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990063004/80001

[commit-bot: I haz the power, 2016-05-19 21:44:28]

Description was changed from

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
TBR=pfeldman
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
TBR=pfeldman
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-05-19 21:44:29]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-19 21:45:56]

Description was changed from

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
TBR=pfeldman
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move bindToCurrentThread out to the creators of WebGL contexts.

The ContextProvider::BindToCurrentThread method is going away, with
the ContextProvider being bound to whatever thread it is created on
and deferred creation via helper Factory classes.

The WebGL contexts currently optionally BindToCurrentThread when
the context is created. Instead, move it to the caller that creates
the provider.

In the future the WebGraphicsContext3DProvider will hold the
ContextProvider::Factory, and when bindToCurrentThread is called
it will use the Factory to instantiate the real ContextProvider.

In order to keep this optional, just have the creator of the context
always call WebGraphicsContext3DProvider::bindToCurrentThread.

R=kbr@chromium.org
TBR=pfeldman
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/f07993965cc4250d01226f5260736608957e91d8
Cr-Commit-Position: refs/heads/master@{#394877}
==========

[commit-bot: I haz the power, 2016-05-19 21:45:57]

Patchset 5 (id:??) landed as
https://crrev.com/f07993965cc4250d01226f5260736608957e91d8
Cr-Commit-Position: refs/heads/master@{#394877}