Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 1990063004: Move bindToCurrentThread out to the creators of WebGL contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bindwebgl: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/renderer_blink_platform_impl.cc
diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc
index 94976ac52f2a57a92ceb311547d8540f04d3a0f1..478cf8161ce32ddb714a6467722646d3b59492e7 100644
--- a/content/renderer/renderer_blink_platform_impl.cc
+++ b/content/renderer/renderer_blink_platform_impl.cc
@@ -1028,8 +1028,7 @@ RendererBlinkPlatformImpl::createOffscreenGraphicsContext3DProvider(
const blink::Platform::ContextAttributes& web_attributes,
const blink::WebURL& top_document_web_url,
blink::WebGraphicsContext3DProvider* share_provider,
- blink::Platform::GraphicsInfo* gl_info,
- blink::Platform::WillBindToCurrentThread will_bind_to_current_thread) {
+ blink::Platform::GraphicsInfo* gl_info) {
DCHECK(gl_info);
if (!RenderThreadImpl::current()) {
std::string error_message("Failed to run in Current RenderThreadImpl");
@@ -1052,9 +1051,6 @@ RendererBlinkPlatformImpl::createOffscreenGraphicsContext3DProvider(
static_cast<content::WebGraphicsContext3DProviderImpl*>(share_provider);
ContextProviderCommandBuffer* share_context = nullptr;
- if (will_bind_to_current_thread == blink::Platform::DoNotBindToCurrentThread)
- DCHECK(!share_provider_impl);
-
// WebGL contexts must fail creation if the share group is lost.
if (share_provider_impl) {
auto* gl = share_provider_impl->contextGL();
@@ -1098,15 +1094,6 @@ RendererBlinkPlatformImpl::createOffscreenGraphicsContext3DProvider(
GURL(top_document_web_url), gpu_preference, automatic_flushes,
support_locking, gpu::SharedMemoryLimits(), attributes, share_context,
command_buffer_metrics::OFFSCREEN_CONTEXT_FOR_WEBGL));
- if (will_bind_to_current_thread == blink::Platform::BindToCurrentThread) {
- if (!provider->BindToCurrentThread()) {
- std::string error_message(
- "ContextProviderCommandBuffer::BindToCurrentThread failed: ");
- error_message.append(gl_info->errorMessage.utf8());
- gl_info->errorMessage = WebString::fromUTF8(error_message);
- return nullptr;
- }
- }
return new WebGraphicsContext3DProviderImpl(std::move(provider));
}
« no previous file with comments | « content/renderer/renderer_blink_platform_impl.h ('k') | content/renderer/webgraphicscontext3d_provider_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698