MD Settings: About page, add an explicit 'aboutPageReady' signal.

MD Settings: About page, add an explicit 'aboutPageReady' signal.

This is needed by follow up CL, such that AllowJavascript() is called without
triggering a 'update-status-changed' event.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/03bb8f02c492022a3d682314529845e90cb9dba5
Cr-Commit-Position: refs/heads/master@{#394670}

[dpapad, 2016-05-17 23:54:00]

Description was changed from

==========
MD Settings: About page, add an explicit 'aboutPageReady' signal.

This is needed by follow up CL, such that AllowJavascript() is called without
triggering a 'update-status-changed' event.

BUG=603625
==========

to

==========
MD Settings: About page, add an explicit 'aboutPageReady' signal.

This is needed by follow up CL, such that AllowJavascript() is called without
triggering a 'update-status-changed' event.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-18 01:06:08]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2016-05-18 21:58:12]

On 2016/05/18 at 01:06:09, dpapad wrote:
> 

Friendly ping.

[tommycli, 2016-05-18 22:33:43]

lgtm sorry for the delay. I forgot about this review.

I assume you no longer want to refresh the update status on every load?

[dpapad, 2016-05-18 23:16:00]

On 2016/05/18 at 22:33:43, tommycli wrote:
> lgtm sorry for the delay. I forgot about this review.
> 
> I assume you no longer want to refresh the update status on every load?

The main reason is (for the about_page.html) that I need to grab some
information from the browser proxy (getCurrentChannel(), getTargetChannel()),
before triggering the 'udpate-status-changed' event. This was impossible before,
because I had to trigger that event first to signify that Javascript is allowed.
This is easier to understand by looking at the next CL,
https://codereview.chromium.org/1987813004/diff/40001/chrome/browser/resource...,
(still WIP though).

Secondary reason is that detailed_build_info.html does not need that event, but
it was calling it only because getCurrentChannel(), getTargetChannel() would
cause the browser to crash, if OnJavascriptAllowed has not been executed yet.
The new model is more flexible by decoupling the event from "page ready" signal.

[tommycli, 2016-05-18 23:32:46]

On 2016/05/18 23:16:00, dpapad wrote:
> On 2016/05/18 at 22:33:43, tommycli wrote:
> > lgtm sorry for the delay. I forgot about this review.
> > 
> > I assume you no longer want to refresh the update status on every load?
> 
> The main reason is (for the about_page.html) that I need to grab some
> information from the browser proxy (getCurrentChannel(), getTargetChannel()),
> before triggering the 'udpate-status-changed' event. This was impossible
before,
> because I had to trigger that event first to signify that Javascript is
allowed.
> This is easier to understand by looking at the next CL,
>
https://codereview.chromium.org/1987813004/diff/40001/chrome/browser/resource...,
> (still WIP though).
> 
> Secondary reason is that detailed_build_info.html does not need that event,
but
> it was calling it only because getCurrentChannel(), getTargetChannel() would
> cause the browser to crash, if OnJavascriptAllowed has not been executed yet.
> The new model is more flexible by decoupling the event from "page ready"
signal.

Sounds good thanks for the explanation!

[dpapad, 2016-05-18 23:53:11]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-05-18 23:53:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989673002/1

[commit-bot: I haz the power, 2016-05-19 04:27:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-19 04:28:53]

Description was changed from

==========
MD Settings: About page, add an explicit 'aboutPageReady' signal.

This is needed by follow up CL, such that AllowJavascript() is called without
triggering a 'update-status-changed' event.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, add an explicit 'aboutPageReady' signal.

This is needed by follow up CL, such that AllowJavascript() is called without
triggering a 'update-status-changed' event.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/03bb8f02c492022a3d682314529845e90cb9dba5
Cr-Commit-Position: refs/heads/master@{#394670}
==========

[commit-bot: I haz the power, 2016-05-19 04:28:54]

Patchset 1 (id:??) landed as
https://crrev.com/03bb8f02c492022a3d682314529845e90cb9dba5
Cr-Commit-Position: refs/heads/master@{#394670}