Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2200)

Unified Diff: chrome/test/data/webui/settings/about_page_tests.js

Issue 1989673002: MD Settings: About page, add an explicit 'aboutPageReady' signal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/about_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/about_page_tests.js
diff --git a/chrome/test/data/webui/settings/about_page_tests.js b/chrome/test/data/webui/settings/about_page_tests.js
index f70c60c538724e3141dc76cf5ff7be94ad445a20..6a0b7bb2da1af4f37a03c4255ff124cffd3849de 100644
--- a/chrome/test/data/webui/settings/about_page_tests.js
+++ b/chrome/test/data/webui/settings/about_page_tests.js
@@ -10,6 +10,7 @@ cr.define('settings_about_page', function() {
*/
var TestAboutPageBrowserProxy = function() {
settings.TestBrowserProxy.call(this, [
+ 'pageReady',
'refreshUpdateStatus',
'openHelpPage',
'openFeedbackDialog',
@@ -34,6 +35,11 @@ cr.define('settings_about_page', function() {
},
/** @override */
+ pageReady: function() {
+ this.methodCalled('pageReady');
+ },
+
+ /** @override */
refreshUpdateStatus: function() {
this.methodCalled('refreshUpdateStatus');
},
@@ -129,7 +135,7 @@ cr.define('settings_about_page', function() {
document.body.appendChild(page);
return Promise.all([
- browserProxy.whenCalled('refreshUpdateStatus'),
+ browserProxy.whenCalled('pageReady'),
browserProxy.whenCalled('getVersionInfo'),
browserProxy.whenCalled('getCurrentChannel'),
]).then(function() {
« no previous file with comments | « chrome/browser/ui/webui/settings/about_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698