chrome/browser/ui/toolbar/app_menu_model.cc - Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.cc

Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviews, fix Mac compile Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/i18n/number_formatting.h ('K') | « chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm ('k') | chrome/browser/ui/views/location_bar/zoom_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/app_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc

index d1d6723473c5c97147e78ee1297606714b55cf98..f5ec492370512f710863a600163133a9d77ee51a 100644

--- a/chrome/browser/ui/toolbar/app_menu_model.cc

+++ b/chrome/browser/ui/toolbar/app_menu_model.cc

@@ -10,9 +10,9 @@

#include "base/command_line.h"

#include "base/debug/debugging_flags.h"

#include "base/debug/profiler.h"

+#include "base/i18n/number_formatting.h"

#include "base/macros.h"

#include "base/metrics/histogram.h"

-#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "build/build_config.h"

@@ -940,8 +940,7 @@ void AppMenuModel::UpdateZoomControls() {

browser_->tab_strip_model()->GetActiveWebContents())

->GetZoomPercent();

}

- zoom_label_ = l10n_util::GetStringFUTF16(

- IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent));

+ zoom_label_ = base::FormatPercent(zoom_percent);

}

void AppMenuModel::OnZoomLevelChanged(