chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm - Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviews, fix Mac compile Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

index 7fb1d0ad10e662aeb9fdec5b54369aebc6dcb65f..478e0a444422f0b34544ee5cf46ea97c76186499 100644

--- a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

@@ -4,6 +4,7 @@

#import "chrome/browser/ui/cocoa/location_bar/zoom_decoration.h"

+#include "base/i18n/number_formatting.h"

#include "base/strings/string16.h"

#include "base/strings/string_number_conversions.h"

#include "chrome/app/chrome_command_ids.h"

@@ -41,9 +42,9 @@ bool ZoomDecoration::UpdateIfNecessary(

}

base::string16 zoom_percent =

- base::IntToString16(zoom_controller->GetZoomPercent());

+ base::FormatPercent(zoom_controller->GetZoomPercent());

NSString* zoom_string =

- l10n_util::GetNSStringFWithFixup(IDS_TOOLTIP_ZOOM, zoom_percent);

+ l10n_util::GetNSStringF(IDS_TOOLTIP_ZOOM, zoom_percent);

if (IsVisible() && [tooltip_ isEqualToString:zoom_string] &&

!default_zoom_changed) {

« base/i18n/number_formatting.h ('K') | « chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm ('k') | chrome/browser/ui/toolbar/app_menu_model.cc » ('j') | no next file with comments »