Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.
Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviews (and merge) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« base/i18n/number_formatting.cc ('K') | « base/i18n/number_formatting.cc ('k') | chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 58266707139973234d8d9675b8ec680434443df5..71013ef1db6a50fc4a0634dd5e16134fc7dbd90c 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -1087,9 +1087,6 @@ are declared in build/common.gypi.
<message name="IDS_ZOOM_MINUS2" desc="The text label of the Make Text Smaller menu item in the merged menu">
&#8722;
</message>
- <message name="IDS_ZOOM_PERCENT" desc="Current pages zoom factor; shown in merged menu">
- <ph name="VALUE">$1<ex>100</ex></ph>%
- </message>
<message name="IDS_ENCODING_MENU" desc="The text label of the Encoding submenu">
&amp;Encoding
</message>
@@ -1161,9 +1158,6 @@ are declared in build/common.gypi.
<message name="IDS_ZOOM_MINUS2" desc="The text label of the Make Text Smaller menu item in the merged menu">
&#8722;
</message>
- <message name="IDS_ZOOM_PERCENT" desc="Current pages zoom factor; shown in merged menu">
- <ph name="VALUE">$1<ex>100</ex></ph>%
- </message>
<message name="IDS_ENCODING_MENU" desc="In Title Case: The text label of the Encoding submenu">
&amp;Encoding
</message>
@@ -7211,7 +7205,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
Translate this page
</message>
<message name="IDS_TOOLTIP_ZOOM" desc="The tooltip for the zoom bubble">
- Zoom: <ph name="VALUE">$1<ex>100</ex></ph>%
+ Zoom: <ph name="VALUE">$1<ex>100%</ex></ph>
jungshik at Google 2016/05/18 22:35:03 nit: Now it has '%' sign. ph name might as well be
Greg Levin 2016/05/19 15:42:13 Done.
</message>
<message name="IDS_TOOLTIP_ZOOM_EXTENSION_ICON" desc="The tooltip for the extension icon in the zoom bubble">
This page was zoomed by the "<ph name="NAME">$1<ex>Google Cast</ex></ph>" extension
« base/i18n/number_formatting.cc ('K') | « base/i18n/number_formatting.cc ('k') | chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698