chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm - Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviews (and merge) Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm » ('j') | chrome/browser/ui/views/location_bar/zoom_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm b/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

index 58390dae94010d643ac194533aea728b2c0d9174..b9f38ebff29e38d3f2c8bf89093de2e2f67118c5 100644

--- a/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

@@ -4,6 +4,7 @@

#include "chrome/browser/ui/cocoa/browser/zoom_bubble_controller.h"

+#include "base/i18n/number_formatting.h"

#include "base/mac/foundation_util.h"

#include "base/strings/string_number_conversions.h"

#import "chrome/browser/ui/cocoa/info_bubble_view.h"

tapted 2016/05/19 03:08:42 insert `#include "base/strings/sys_string_conversi

Greg Levin 2016/05/19 15:42:13 Done. Thanks!!

@@ -147,8 +148,7 @@ void SetZoomBubbleAutoCloseDelayForTesting(NSTimeInterval time_interval) {

return;

int percent = zoomController->GetZoomPercent();

- NSString* string =

- l10n_util::GetNSStringF(IDS_ZOOM_PERCENT, base::IntToString16(percent));

+ NSString* string = base::SysUTF16ToNSString(base::FormatPercent(percent));

[zoomPercent_ setAttributedStringValue:

[self attributedStringWithString:string

fontSize:kTextFontSize]];