chrome/browser/task_management/providers/web_contents/tab_contents_task.cc - Issue 1989393003: Fix bugs in the new task manager Impl so that ported old browsertests pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/providers/web_contents/tab_contents_task.cc

Issue 1989393003: Fix bugs in the new task manager Impl so that ported old browsertests pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nicks comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/providers/web_contents/devtools_task.cc ('k') | chrome/browser/task_management/task_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/providers/web_contents/tab_contents_task.cc

diff --git a/chrome/browser/task_management/providers/web_contents/tab_contents_task.cc b/chrome/browser/task_management/providers/web_contents/tab_contents_task.cc

index 55271f9245546e3dee721490520b4ab7e979d9f5..6168ac4a4ac71825240ecd096e93e31536ef0b0b 100644

--- a/chrome/browser/task_management/providers/web_contents/tab_contents_task.cc

+++ b/chrome/browser/task_management/providers/web_contents/tab_contents_task.cc

@@ -59,7 +59,7 @@ base::string16 TabContentsTask::GetCurrentTitle() const {

extensions::ExtensionRegistry::Get(profile);

GURL url = web_contents()->GetURL();

- bool is_app = process_map->Contains(process_id()) &&

+ bool is_app = process_map->Contains(GetChildProcessUniqueID()) &&

extension_registry->enabled_extensions().GetAppByURL(url) != nullptr;

bool is_extension = HostsExtension(web_contents());

bool is_incognito = profile->IsOffTheRecord();