Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: chrome/browser/task_management/providers/web_contents/devtools_task.cc

Issue 1989393003: Fix bugs in the new task manager Impl so that ported old browsertests pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nicks comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/web_contents/devtools_task.cc
diff --git a/chrome/browser/task_management/providers/web_contents/devtools_task.cc b/chrome/browser/task_management/providers/web_contents/devtools_task.cc
index 84e190737177e492141f812af050c4bed6054693..3bafc76cb19665e459c5ef34cb469cff48ea4c43 100644
--- a/chrome/browser/task_management/providers/web_contents/devtools_task.cc
+++ b/chrome/browser/task_management/providers/web_contents/devtools_task.cc
@@ -9,21 +9,10 @@
namespace task_management {
DevToolsTask::DevToolsTask(content::WebContents* web_contents)
- : RendererTask(RendererTask::GetTitleFromWebContents(web_contents),
- RendererTask::GetFaviconFromWebContents(web_contents),
- web_contents,
- web_contents->GetRenderProcessHost()) {
+ : TabContentsTask(web_contents) {
}
DevToolsTask::~DevToolsTask() {
}
-void DevToolsTask::UpdateTitle() {
- // In the case of a devtools tab, we just ignore this event.
-}
-
-void DevToolsTask::UpdateFavicon() {
- // In the case of a devtools tab, we just ignore this event.
-}
-
} // namespace task_management

Powered by Google App Engine
This is Rietveld 408576698