Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1989383002: [Layout API] Use FrameView::layoutViewItem() in WebFrameTest.cpp (Closed)

Created:
4 years, 7 months ago by pilgrim_google
Modified:
4 years, 7 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use FrameView::layoutViewItem() in WebFrameTest.cpp There are several references to layoutView() which can be replaced 1-1 with layoutViewItem(). I had to add two methods to LayoutBoxItem, logicalWidth() and logicalHeight(). BUG=499321 Committed: https://crrev.com/c55a2befcf58f361ad6d924818ac84da7c8de2dc Cr-Commit-Position: refs/heads/master@{#394517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 8 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 7 months ago (2016-05-18 18:21:09 UTC) #2
eae
lgtm
4 years, 7 months ago (2016-05-18 18:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989383002/1
4 years, 7 months ago (2016-05-18 18:23:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 19:59:32 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 20:00:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c55a2befcf58f361ad6d924818ac84da7c8de2dc
Cr-Commit-Position: refs/heads/master@{#394517}

Powered by Google App Engine
This is Rietveld 408576698