Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issue 1989363005: Graceful idle callback cancellation with invalid IDs. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken, rmcilroy
CC:
chromium-reviews, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Graceful idle callback cancellation with invalid IDs. R= BUG=613073 Committed: https://crrev.com/9cd8dda63564587b273620dbb56aa331f3dacbdc Cr-Commit-Position: refs/heads/master@{#394768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/basic.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-19 13:09:22 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-19 13:19:11 UTC) #3
rmcilroy
Thanks for doing this, I was just about to look into that bug so you ...
4 years, 7 months ago (2016-05-19 13:42:44 UTC) #4
sof
On 2016/05/19 13:42:44, rmcilroy wrote: > Thanks for doing this, I was just about to ...
4 years, 7 months ago (2016-05-19 13:51:37 UTC) #5
rmcilroy
On 2016/05/19 13:51:37, sof wrote: > On 2016/05/19 13:42:44, rmcilroy wrote: > > Thanks for ...
4 years, 7 months ago (2016-05-19 13:57:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989363005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989363005/1
4 years, 7 months ago (2016-05-19 14:04:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 14:55:57 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 14:57:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cd8dda63564587b273620dbb56aa331f3dacbdc
Cr-Commit-Position: refs/heads/master@{#394768}

Powered by Google App Engine
This is Rietveld 408576698