third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h - Issue 1989363005: Graceful idle callback cancellation with invalid IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h

Issue 1989363005: Graceful idle callback cancellation with invalid IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/basic.html ('k') | third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h

diff --git a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h

index 27d9878a90ed4678d58bcd82d16f478e1c85d0e1..f86a6db13afe79b1e39b211257432255f5796467 100644

--- a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h

+++ b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h

@@ -43,6 +43,14 @@ public:

private:

explicit ScriptedIdleTaskController(ExecutionContext*);

+ int nextCallbackId();

+ bool isValidCallbackId(int id)

+ {

+ using Traits = HashTraits<CallbackId>;

+ return !Traits::isDeletedValue(id) && !WTF::isHashTraitsEmptyValue<Traits, CallbackId>(id);

+ }

void runCallback(CallbackId, double deadlineSeconds, IdleDeadline::CallbackType);

WebScheduler* m_scheduler; // Not owned.