Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989263002: [keys] KeyAccumulator cleanups (Closed)

Created:
4 years, 7 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[keys] KeyAccumulator cleanups Move most of JSReceiver::GetKeys to the KeyAccumulator BUG= Committed: https://crrev.com/e4c3be5af31808d006991efb52d1cb939519e84a Cr-Commit-Position: refs/heads/master@{#36321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M src/keys.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/keys.cc View 2 chunks +28 lines, -1 line 0 comments Download
M src/objects.cc View 3 chunks +2 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-18 12:42:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989263002/1
4 years, 7 months ago (2016-05-18 13:11:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 13:41:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 13:43:15 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e4c3be5af31808d006991efb52d1cb939519e84a
Cr-Commit-Position: refs/heads/master@{#36321}

Powered by Google App Engine
This is Rietveld 408576698