Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: src/keys.h

Issue 1989263002: [keys] KeyAccumulator cleanups (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/keys.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/keys.h
diff --git a/src/keys.h b/src/keys.h
index d2a04f32e228b8d3b9e9a4672c01087e504ef858..c73f10911df3c81f54ea875fa12bd1bfbfcf3b68 100644
--- a/src/keys.h
+++ b/src/keys.h
@@ -36,6 +36,11 @@ class KeyAccumulator final BASE_EMBEDDED {
: isolate_(isolate), type_(type), filter_(filter) {}
~KeyAccumulator();
+ static MaybeHandle<FixedArray> GetKeys(Handle<JSReceiver> object,
+ KeyCollectionType type,
+ PropertyFilter filter,
+ GetKeysConversion keys_conversion,
+ bool filter_proxy_keys);
Handle<FixedArray> GetKeys(GetKeysConversion convert = KEEP_NUMBERS);
Maybe<bool> CollectKeys(Handle<JSReceiver> receiver,
Handle<JSReceiver> object);
@@ -115,8 +120,6 @@ class FastKeyAccumulator {
KeyCollectionType type, PropertyFilter filter)
: isolate_(isolate), receiver_(receiver), type_(type), filter_(filter) {
Prepare();
- // TODO(cbruni): pass filter_ directly to the KeyAccumulator.
- USE(filter_);
}
bool is_receiver_simple_enum() { return is_receiver_simple_enum_; }
@@ -134,9 +137,9 @@ class FastKeyAccumulator {
Handle<JSReceiver> receiver_;
KeyCollectionType type_;
PropertyFilter filter_;
+ bool filter_proxy_keys_ = true;
bool is_receiver_simple_enum_ = false;
bool has_empty_prototype_ = false;
- bool filter_proxy_keys_ = true;
DISALLOW_COPY_AND_ASSIGN(FastKeyAccumulator);
};
« no previous file with comments | « no previous file | src/keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698