Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1989233002:
only use kAccessibilityEnabled inside USE_GCONF ifdef blocks (Closed)
|
Created:
4 years, 7 months ago by Mostyn Bramley-Moore Modified:
4 years, 7 months ago CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiononly use kAccessibilityEnabled inside USE_GCONF ifdef blocks
Followup to:
https://codereview.chromium.org/1990453002
https://codereview.chromium.org/1988213002
BUG=486077
Committed: https://crrev.com/d0818dbee29e16108cfe3b2eac4df3e0e86e2de0
Cr-Commit-Position: refs/heads/master@{#395047}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989233002/1
Description was changed from ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks BUG= ========== to ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to https://codereview.chromium.org/1990453002 BUG=486077 ==========
mostynb@opera.com changed reviewers: + dmazzoni@chromium.org, kraynov@chromium.org
@dmazzoni, kraynov: PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, but the change was reverted - let's see if we can re-land it with this change.
sgtm- thanks.
Description was changed from ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to https://codereview.chromium.org/1990453002 BUG=486077 ========== to ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to: https://codereview.chromium.org/1990453002 https://codereview.chromium.org/1988213002 BUG=486077 ==========
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989233002/1
This relanded without my fix, therefore queueing this.
Message was sent while issue was closed.
Description was changed from ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to: https://codereview.chromium.org/1990453002 https://codereview.chromium.org/1988213002 BUG=486077 ========== to ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to: https://codereview.chromium.org/1990453002 https://codereview.chromium.org/1988213002 BUG=486077 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to: https://codereview.chromium.org/1990453002 https://codereview.chromium.org/1988213002 BUG=486077 ========== to ========== only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to: https://codereview.chromium.org/1990453002 https://codereview.chromium.org/1988213002 BUG=486077 Committed: https://crrev.com/d0818dbee29e16108cfe3b2eac4df3e0e86e2de0 Cr-Commit-Position: refs/heads/master@{#395047} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d0818dbee29e16108cfe3b2eac4df3e0e86e2de0 Cr-Commit-Position: refs/heads/master@{#395047} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
